Core: Plan concurrently if there are multiple delete manifests #8388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokolnychyi
commented
Aug 24, 2023
| @@ -87,7 +87,7 @@ public CloseableIterable<FileScanTask> doPlanFiles() { | |||
| manifestGroup = manifestGroup.ignoreResiduals(); | |||
| } | |||
|
|
|||
| if (dataManifests.size() > 1 && shouldPlanWithExecutor()) { | |||
| if (shouldPlanWithExecutor() && (dataManifests.size() > 1 || deleteManifests.size() > 1)) { | |||
There was a problem hiding this comment.
Data and deletes are planned separately. If we are scanning 1 data manifest, it does not mean we shouldn't parallelize the planing of deletes.
ManifestGroup planWith(ExecutorService newExecutorService) {
this.executorService = newExecutorService;
deleteIndexBuilder.planWith(newExecutorService);
return this;
}
singhpk234
approved these changes
Aug 24, 2023
szehon-ho
approved these changes
Aug 24, 2023
|
Thanks, @singhpk234 @szehon-ho! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that data scans use a thread pool when there are more than 1 delete manifest, regardless of the number of data manifests