Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: fix glue catalog when using aws credentials #8209

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

bmaisonn
Copy link
Contributor

@bmaisonn bmaisonn commented Aug 2, 2023

Fixes #8047 by using the right parameters in session initialization

@github-actions github-actions bot added the python label Aug 2, 2023
@bmaisonn
Copy link
Contributor Author

bmaisonn commented Aug 2, 2023

i guess having an integration test for this could be nice but i'm not sure how to do it in that case.

@Fokko Fokko added this to the PyIceberg 0.5.0 release milestone Aug 2, 2023
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bmaisonn I agree, but now we also overlooked it in the test. Thanks for fixing this

@Fokko Fokko merged commit dada24d into apache:master Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyIceberg not able to connect to Glue catalogs
2 participants