AWS, GCP: Allow access to underlying storage client in FileIO #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good idea. For context, we've been talking about how to use FileIO for things that it isn't intended. We want to use FileIO because it is already configured to work with tables and credentials, but it purposely doesn't expose a filesystem like view. The solution is to be able to get the client that is configured and use it for more custom operations. I think it's reasonable to make the client available like this. +1 from me, but I'll leave this open for a while so others can comment. FYI @jackye1995, @amogh-jahagirdar. |
bryanck
changed the title
|
Thanks, @bryanck! |
nastra
pushed a commit
to nastra/iceberg
that referenced
this pull request
Aug 15, 2023
* Spark: Update antlr4 to match Spark 3.4 (apache#7824) * Parquet: Revert workaround for resource usage with zstd (apache#7834) * GCP: fix single byte read in GCSInputStream (apache#8071) * GCP: fix byte read in GCSInputStream * add test * Parquet: Cache codecs by name and level (apache#8182) * GCP: Add prefix and bulk operations to GCSFileIO (apache#8168) * AWS, GCS: Allow access to underlying storage client (apache#8208) * spotless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
client()methods inS3FileIOandGCSFileIOpublic, which allows more flexibility in using a file IO instance for storage operations that might not be defined in the interface.