Spark 3.4: Support setting current snapshot with ref #8163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
changed the title
|
@jackye1995 @hililiwei please help review this idea. |
nastra
reviewed
Jul 27, 2023
...3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/SetCurrentSnapshotProcedure.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Jul 28, 2023
...3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/SetCurrentSnapshotProcedure.java
Outdated
Show resolved
Hide resolved
manuzhang
force-pushed
the
set_current_snapshot_tag
branch
from
8fb8ff3
to
1d6a7c9
Compare
manuzhang
force-pushed
the
set_current_snapshot_tag
branch
from
1d6a7c9
to
744d706
Compare
manuzhang
changed the title
aokolnychyi
reviewed
Aug 9, 2023
...3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/SetCurrentSnapshotProcedure.java
Outdated
Show resolved
Hide resolved
aokolnychyi
reviewed
Aug 9, 2023
...3.4/spark/src/main/java/org/apache/iceberg/spark/procedures/SetCurrentSnapshotProcedure.java
Outdated
Show resolved
Hide resolved
|
I had two minor comments but it looks good otherwise. |
|
@aokolnychyi comments addressed and I've also updated the docs. |
|
@aokolnychyi can you help take another look? |
aokolnychyi
approved these changes
Aug 15, 2023
|
Thanks, @manuzhang! Thanks for reviewing, @nastra! |
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 25, 2023
Back-port of apache#8163 to `spark/v3.3`, `spark/v3.2` and `spark/v3.1`
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 25, 2023
Back-port of apache#8163 to `spark/v3.3`, `spark/v3.2` and `spark/v3.1`
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 25, 2023
Back-port of apache#8163 to `spark/v3.3`, `spark/v3.2` and `spark/v3.1`
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 25, 2023
Back-port of apache#8163 to `spark/v3.3`, `spark/v3.2` and `spark/v3.1`
manuzhang
added a commit
to manuzhang/iceberg
that referenced
this pull request
Aug 26, 2023
Back-port of apache#8163 to `spark/v3.3`, `spark/v3.2` and `spark/v3.1`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_current_snapshotprocedure currently only supports setting snapshot with id. It's much more convenient for users to set snapshot with ref (e.g. use date as a tag for a daily job). This PR adds support for that.