Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Make compatibility example consistent. #10781

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Docs: Make compatibility example consistent. #10781

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa218d2
Make compatibility example consistent.
emkornfield Jul 25, 2024
6e99fb7
Update site/docs/contribute.md
amogh-jahagirdar Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions site/docs/contribute.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,8 @@ public interface ManageSnapshots extends PendingUpdate<Snapshot> {
// existing code...

// adding this method introduces an API-breaking change
// since existing classes implementing ManagedSnapshots
amogh-jahagirdar marked this conversation as resolved.
Show resolved Hide resolved
// will no longer compile.
ManageSnapshots createBranch(String name);
}
```
Expand All @@ -207,8 +209,8 @@ public class SnapshotManager implements ManageSnapshots {
// existing code...

@Override
public ManageSnapshots createBranch(String name, long snapshotId) {
updateSnapshotReferencesOperation().createBranch(name, snapshotId);
public ManageSnapshots createBranch(String name) {
updateSnapshotReferencesOperation().createBranch(name);
return this;
}
}
Expand Down