Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Make compatibility example consistent. #10781

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

emkornfield
Copy link
Contributor

  • make implementation match definition in interface
  • clarify why adding a new interface method breaks compatibility.

@github-actions github-actions bot added the docs label Jul 25, 2024
@emkornfield emkornfield changed the title Make compatibility example consistent. Minor: Make compatibility example consistent. Jul 25, 2024
@emkornfield
Copy link
Contributor Author

@Fokko would you mind taking a look?

Copy link
Contributor

@amogh-jahagirdar amogh-jahagirdar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @emkornfield!

site/docs/contribute.md Outdated Show resolved Hide resolved
@amogh-jahagirdar amogh-jahagirdar changed the title Minor: Make compatibility example consistent. Docs: Make compatibility example consistent. Jul 25, 2024
@amogh-jahagirdar amogh-jahagirdar merged commit 48841a9 into apache:main Jul 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants