Add EnumConfParser to SparkConfParser #10311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aokolnychyi |
nastra
approved these changes
May 11, 2024
aokolnychyi
reviewed
May 13, 2024
| @@ -197,6 +201,34 @@ private Duration toDuration(String time) { | |||
| } | |||
| } | |||
|
|
|||
| class EnumConfParser<T extends Enum<T>> extends ConfParser<EnumConfParser<T>, T> { | |||
| private T defaultValue; | |||
| private final Function<String, T> toEnum; | |||
There was a problem hiding this comment.
Minor: We usually have final vars before mutable. Can we switch the order of these two?
aokolnychyi
approved these changes
May 13, 2024
aokolnychyi
reviewed
May 13, 2024
| @@ -70,6 +70,10 @@ public DurationConfParser durationConf() { | |||
| return new DurationConfParser(); | |||
| } | |||
|
|
|||
| public <T extends Enum<T>> EnumConfParser<T> enumConf(Function<String, T> func) { | |||
There was a problem hiding this comment.
Minor: What about func -> toEnum?
aokolnychyi
reviewed
May 13, 2024
| .enumConf(PlanningMode::fromName) | ||
| .sessionConf(SparkSQLProperties.DATA_PLANNING_MODE) | ||
| .tableProperty(TableProperties.DATA_PLANNING_MODE) | ||
| .defaultValue(PlanningMode.fromName(TableProperties.PLANNING_MODE_DEFAULT)) |
There was a problem hiding this comment.
We can also offer defaultValue(String value) in addition to defaultValue(T value) and call toEnum(value) internally.
aokolnychyi
approved these changes
May 13, 2024
|
Thanks @aokolnychyi @nastra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
EnumConfParsertoSparkConfParserto parse Enum type properties