Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Delegate json deserialization to Pydantic #7982

Closed
Fokko opened this issue Jul 4, 2023 · 1 comment · Fixed by #8286
Closed

Python: Delegate json deserialization to Pydantic #7982

Fokko opened this issue Jul 4, 2023 · 1 comment · Fixed by #8286

Comments

@Fokko
Copy link
Contributor

Fokko commented Jul 4, 2023

Feature Request / Improvement

Currently, we decode a bytestream using json.load in serializers.py. It would be better to have this directly done by Pydantic, to avoid constructing a Python dictionary.

Query engine

None
@aless10
Copy link
Contributor

aless10 commented Aug 5, 2023

Hi @Fokko, I would like to contribute. Do you think this issue can be a good starting point to understand how it works? Thanks

@aless10 aless10 mentioned this issue Aug 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Python: Delegate serialization to pydantic aless10/iceberg
2 participants
@Fokko @aless10