Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated APIs for 1.4.0 release #7837

Closed
nastra opened this issue Jun 14, 2023 · 7 comments
Closed

Remove deprecated APIs for 1.4.0 release #7837

nastra opened this issue Jun 14, 2023 · 7 comments
Labels
AWS java Pull requests that update Java code
Milestone
Iceberg 1.4.0

Comments

@nastra
Copy link
Contributor

nastra commented Jun 14, 2023

Feature Request / Improvement

There are a few deprecated APIs that should be removed before releasing 1.4.0

Query engine

None
@nastra nastra assigned nastra and unassigned nastra Jun 14, 2023
@nastra
Copy link
Contributor Author

nastra commented Jul 4, 2023

I've handled most deprecations in #7987. @akshayakp97 could you handle the deprecations in AwsProperties please?

@Fokko Fokko added AWS java Pull requests that update Java code labels Sep 1, 2023
@Fokko Fokko added this to the Iceberg 1.4.0 milestone Sep 1, 2023
@jbonofre
Copy link
Member

jbonofre commented Sep 11, 2023 •
edited
Loading

Let me double check, I think I have a PR ready about AwsProperties. I'm doing the whole pass for 1.4.0.

@aokolnychyi
Copy link
Contributor

Let me know once there is PR, @jbonofre.

@jbonofre
Copy link
Member

@aokolnychyi Hey Anton. I'm rebasing and doing new tests, I should be able to open the PR later today or tomorrow.

@aokolnychyi
Copy link
Contributor

Perfect, please tag it here for visibility.

@jbonofre
Copy link
Member

#8612

@Fokko @aokolnychyi if you guys can take a look.

I have one question: I had to update GlueCatalog to pass S3FileIOProperties in addition of AwsProperties (in order to have required S3 properties/configuration). Is it OK for you guys ?

@jbonofre jbonofre mentioned this issue Sep 21, 2023
Merged
@jbonofre
Copy link
Member

#8612 has been merged. I think we can close this issue right ?

@nastra nastra closed this as completed Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AWS java Pull requests that update Java code
Projects
None yet
Milestone
Iceberg 1.4.0
Development

No branches or pull requests
4 participants
@jbonofre @nastra @Fokko @aokolnychyi