diff --git a/Makefile b/Makefile index 61af139a16..3254aef115 100644 --- a/Makefile +++ b/Makefile @@ -54,9 +54,7 @@ check-license: cd $(DIR); sh scripts/check-license.sh clippy: - cd $(DIR); cargo clippy --all-targets --all-features --workspace -- -D warnings \ - -A clippy::result_large_err -A clippy::box_default -A clippy::extra-unused-lifetimes \ - -A clippy::only-used-in-recursion + cd $(DIR); cargo clippy --all-targets --all-features --workspace -- -D warnings # test with address sanitizer asan-test: diff --git a/analytic_engine/src/sst/parquet/meta_data.rs b/analytic_engine/src/sst/parquet/meta_data.rs index d5ef18cd16..f34f59b2b3 100644 --- a/analytic_engine/src/sst/parquet/meta_data.rs +++ b/analytic_engine/src/sst/parquet/meta_data.rs @@ -388,10 +388,10 @@ mod tests { let parquet_filter = ParquetFilter { row_group_filters: vec![ RowGroupFilter { - column_filters: vec![None, Some(Box::new(Xor8Filter::default()))], + column_filters: vec![None, Some(Box::::default() as _)], }, RowGroupFilter { - column_filters: vec![Some(Box::new(Xor8Filter::default())), None], + column_filters: vec![Some(Box::::default() as _), None], }, ], }; diff --git a/clippy.toml b/clippy.toml new file mode 100644 index 0000000000..f1578e01ec --- /dev/null +++ b/clippy.toml @@ -0,0 +1 @@ +large-error-threshold = 1024 diff --git a/query_engine/src/logical_optimizer/type_conversion.rs b/query_engine/src/logical_optimizer/type_conversion.rs index 77f2579903..1f5a5ea9e3 100644 --- a/query_engine/src/logical_optimizer/type_conversion.rs +++ b/query_engine/src/logical_optimizer/type_conversion.rs @@ -29,6 +29,7 @@ use log::debug; pub struct TypeConversion; impl OptimizerRule for TypeConversion { + #[allow(clippy::only_used_in_recursion)] fn try_optimize( &self, plan: &LogicalPlan, diff --git a/sql/src/planner.rs b/sql/src/planner.rs index 9a22666096..6af112fb15 100644 --- a/sql/src/planner.rs +++ b/sql/src/planner.rs @@ -1001,7 +1001,7 @@ fn parse_column(col: &ColumnDef) -> Result { } // Ensure default value option of columns are valid. -fn ensure_column_default_value_valid<'a, P: MetaProvider>( +fn ensure_column_default_value_valid( columns: &[ColumnSchema], meta_provider: &ContextProviderAdapter<'_, P>, ) -> Result<()> {