Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Review and made uniform the way a string's trim is applied where needed #2836

Open
sramazzina opened this issue Apr 20, 2023 · 1 comment

Comments

@sramazzina
Copy link
Contributor

What would you like to happen?

In Hop, there are a lot of transforms where in their dialog gives the possibility to trim strings (es. DatabaseLookup, StringOperations, TextFileOutput, other ). Any transform uses a different approach to perform the string's trim. We would like to choose a new approach to perform string's trim (maybe by leveraging on Java String.trim function) and apply a refactoring to Hop code so that this same approach must be used everywhere needed

This issue is also in relationship with #2806

Issue Priority

Priority: 3

Issue Component

Component: Transforms

@github-actions github-actions bot added P3 Nice to have Transforms labels Apr 20, 2023
@sramazzina sramazzina added this to the 3.0 milestone Apr 20, 2023
@sramazzina sramazzina mentioned this issue Apr 20, 2023
5 tasks
@kmeyer-mbs
Copy link

Hi,
I would like to add one more aspect. I have just run into the problem that the Trim option in the dialogues not only deletes spaces but also non-printable characters. I could only solve this by performing the trimming via the JavaScript function rtrim() in a separate transformation.
From my point of view, more precise documentation of which form of trim is used and, if possible, influencing the type of trimming makes sense.

Thanks!
Knut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants