Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Cleanup XML of transform String Operations #1938

Open
hansva opened this issue Dec 7, 2022 · 2 comments
Open

[Task]: Cleanup XML of transform String Operations #1938

hansva opened this issue Dec 7, 2022 · 2 comments
Labels

Comments

@hansva
Copy link
Contributor

hansva commented Dec 7, 2022

What needs to happen?

Cleanup XML of transform String Operations

Issue Priority

Priority: 3

Issue Component

Component: Metadata

@gvdutra
Copy link
Contributor

gvdutra commented Jun 28, 2023

I can see several tasks to cleanup XML of transform. could you please elaborate more what needs to be done? Thank you.

@hansva
Copy link
Contributor Author

hansva commented Jun 29, 2023

Hi Gabriel!
Yes I can explain. All these tickets are technical debt that we want to cleanup.
A good example can be found in following PRs #2963, #2910 and there are many more examples.

We want to get rid of the getXml() and loadXml() methods in the Action classes and the TransformMeta classes.
for this we have a system with annotations @HopMetadataProperty() If we clean all of this we can in a later stage move to json or yaml representations of our pipelines and workflows.

Some extra things to take into account is when cleaning this up all arrays have to be moved to Lists.

The best way to get started on this is to start with an Action eg. #1992 as these usually do not have complex nested XML. Starting with a transform (especially those with many options and nested structures (file/field lists) can become quite complex.

If you start on these and ever get stuck feel free to create a draft PR and ask for some help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants