From d2b310bca8140515b436aa34b2bda5c8d0236803 Mon Sep 17 00:00:00 2001 From: Reid Chan Date: Wed, 14 Aug 2019 10:27:55 +0800 Subject: [PATCH] HBASE-22774 [WAL] RegionGroupingStrategy loses its function after split Signed-off-by: Peter Somogyi Conflicts: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java --- .../hadoop/hbase/regionserver/HRegion.java | 6 +- .../hbase/wal/BoundedGroupingStrategy.java | 2 +- .../hbase/wal/NamespaceGroupingStrategy.java | 7 +- .../hbase/wal/RegionGroupingProvider.java | 3 +- .../regionserver/TestSplitTransaction.java | 304 +++++++++++++++++- 5 files changed, 303 insertions(+), 19 deletions(-) diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java index 33e953fdec85..c988863ea26c 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java @@ -6996,9 +6996,11 @@ HRegion createDaughterRegionFromSplits(final HRegionInfo hri) throws IOException // Move the files from the temporary .splits to the final /table/region directory fs.commitDaughterRegion(hri); + // rsServices can be null in UT + WAL daughterWAL = rsServices == null ? getWAL() :rsServices.getWAL(hri); // Create the daughter HRegion instance - HRegion r = HRegion.newHRegion(this.fs.getTableDir(), this.getWAL(), fs.getFileSystem(), - this.getBaseConf(), hri, this.getTableDesc(), rsServices); + HRegion r = HRegion.newHRegion(this.fs.getTableDir(), daughterWAL, + fs.getFileSystem(), this.getBaseConf(), hri, this.getTableDesc(), rsServices); r.readRequestsCount.set(this.getReadRequestsCount() / 2); r.writeRequestsCount.set(this.getWriteRequestsCount() / 2); return r; diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java index 06f879234ca1..b3366c2d0621 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/BoundedGroupingStrategy.java @@ -72,7 +72,7 @@ public void init(Configuration config, String providerId) { int regionGroupNumber = config.getInt(NUM_REGION_GROUPS, DEFAULT_NUM_REGION_GROUPS); groupNames = new String[regionGroupNumber]; for (int i = 0; i < regionGroupNumber; i++) { - groupNames[i] = providerId + GROUP_NAME_DELIMITER + "regiongroup-" + i; + groupNames[i] = "regiongroup-" + i; } } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java index 619359202100..7b100cda6b89 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/NamespaceGroupingStrategy.java @@ -31,7 +31,6 @@ */ @InterfaceAudience.Private public class NamespaceGroupingStrategy implements RegionGroupingStrategy { - private String providerId; @Override public String group(byte[] identifier, byte[] namespace) { @@ -41,12 +40,10 @@ public String group(byte[] identifier, byte[] namespace) { } else { namespaceString = Bytes.toString(namespace); } - return providerId + GROUP_NAME_DELIMITER + namespaceString; + return namespaceString; } @Override - public void init(Configuration config, String providerId) { - this.providerId = providerId; - } + public void init(Configuration config, String providerId) {} } diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java index a72598970fe8..e96f4d76eb01 100644 --- a/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java +++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RegionGroupingProvider.java @@ -61,7 +61,6 @@ public class RegionGroupingProvider implements WALProvider { * Map identifiers to a group number. */ public static interface RegionGroupingStrategy { - String GROUP_NAME_DELIMITER = "."; /** * Given an identifier and a namespace, pick a group. @@ -242,7 +241,7 @@ static class IdentityGroupingStrategy implements RegionGroupingStrategy { public void init(Configuration config, String providerId) {} @Override public String group(final byte[] identifier, final byte[] namespace) { - return Bytes.toString(identifier); + return "identity-" + Bytes.toString(identifier); } } diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java index 1412640ba5d8..f5708baafaac 100644 --- a/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java +++ b/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java @@ -25,11 +25,36 @@ import static org.mockito.Matchers.eq; import static org.mockito.Mockito.*; +import com.google.protobuf.Service; +import org.apache.hadoop.hbase.ChoreService; +import org.apache.hadoop.hbase.CoordinatedStateManager; +import org.apache.hadoop.hbase.ServerName; +import org.apache.hadoop.hbase.client.ClusterConnection; +import org.apache.hadoop.hbase.executor.ExecutorService; +import org.apache.hadoop.hbase.ipc.RpcServerInterface; +import org.apache.hadoop.hbase.master.TableLockManager; +import org.apache.hadoop.hbase.protobuf.generated.HBaseProtos; +import org.apache.hadoop.hbase.protobuf.generated.RegionServerStatusProtos; +import org.apache.hadoop.hbase.quotas.RegionServerQuotaManager; +import org.apache.hadoop.hbase.regionserver.throttle.ThroughputController; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.wal.RegionGroupingProvider; +import org.apache.hadoop.hbase.wal.WAL; +import org.apache.hadoop.hbase.wal.WALProvider; +import org.apache.hadoop.hbase.zookeeper.MetaTableLocator; +import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; import org.mockito.Mockito; import java.io.IOException; +import java.net.InetSocketAddress; import java.util.ArrayList; +import java.util.Collection; import java.util.List; +import java.util.Map; +import java.util.Set; +import java.util.concurrent.ConcurrentMap; import org.apache.hadoop.conf.Configuration; import org.apache.hadoop.fs.FileSystem; @@ -49,7 +74,6 @@ import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment; import org.apache.hadoop.hbase.io.hfile.CacheConfig; import org.apache.hadoop.hbase.io.hfile.LruBlockCache; -import org.apache.hadoop.hbase.testclassification.SmallTests; import org.apache.hadoop.hbase.util.Bytes; import org.apache.hadoop.hbase.util.FSUtils; import org.apache.hadoop.hbase.util.PairOfSameType; @@ -66,7 +90,8 @@ * Test the {@link SplitTransactionImpl} class against an HRegion (as opposed to * running cluster). */ -@Category(SmallTests.class) +@RunWith(Parameterized.class) +@Category(MediumTests.class) public class TestSplitTransaction { private final HBaseTestingUtility TEST_UTIL = new HBaseTestingUtility(); private final Path testdir = @@ -82,15 +107,37 @@ public class TestSplitTransaction { private static boolean preRollBackCalled = false; private static boolean postRollBackCalled = false; - - @Before public void setup() throws IOException { + + private String walProvider; + private String strategy; + + @Parameterized.Parameters + public static final Collection parameters() throws IOException { + List params = new ArrayList<>(4); + params.add(new Object[] { "filesystem", "" }); + params.add(new Object[] { "multiwal", "identity" }); + params.add(new Object[] { "multiwal", "bounded" }); + params.add(new Object[] { "multiwal", "namespace" }); + return params; + } + + public TestSplitTransaction(String walProvider, String strategy) { + this.walProvider = walProvider; + this.strategy = strategy; + } + + @Before + public void setup() throws IOException { this.fs = FileSystem.get(TEST_UTIL.getConfiguration()); TEST_UTIL.getConfiguration().set(CoprocessorHost.REGION_COPROCESSOR_CONF_KEY, CustomObserver.class.getName()); this.fs.delete(this.testdir, true); + TEST_UTIL.getConfiguration().set(WALFactory.WAL_PROVIDER, walProvider); + if (!strategy.isEmpty()) { + TEST_UTIL.getConfiguration().set(RegionGroupingProvider.REGION_GROUPING_STRATEGY, strategy); + } final Configuration walConf = new Configuration(TEST_UTIL.getConfiguration()); FSUtils.setRootDir(walConf, this.testdir); this.wals = new WALFactory(walConf, null, this.getClass().getName()); - this.parent = createRegion(this.testdir, this.wals); RegionCoprocessorHost host = new RegionCoprocessorHost(this.parent, null, TEST_UTIL.getConfiguration()); this.parent.setCoprocessorHost(host); @@ -266,7 +313,7 @@ private SplitTransactionImpl prepareGOOD_SPLIT_ROW(final HRegion parentRegion) assertTrue(count > 0 && count != rowcount); daughtersRowCount += count; } finally { - HRegion.closeHRegion((HRegion)openRegion); + ((HRegion) openRegion).close(); } } assertEquals(rowcount, daughtersRowCount); @@ -352,7 +399,7 @@ public void testCountReferencesFailsSplit() throws IOException { assertTrue(count > 0 && count != rowcount); daughtersRowCount += count; } finally { - HRegion.closeHRegion((HRegion)openRegion); + ((HRegion) openRegion).close(); } } assertEquals(rowcount, daughtersRowCount); @@ -396,11 +443,16 @@ HRegion createRegion(final Path testdir, final WALFactory wals) HColumnDescriptor hcd = new HColumnDescriptor(CF); htd.addFamily(hcd); HRegionInfo hri = new HRegionInfo(htd.getTableName(), STARTROW, ENDROW); - HRegion r = HRegion.createHRegion(hri, testdir, TEST_UTIL.getConfiguration(), htd); + Configuration conf = TEST_UTIL.getConfiguration(); + HRegion r = HRegion.createHRegion(hri, testdir, conf, htd); HRegion.closeHRegion(r); + ServerName sn = ServerName.valueOf("testSplitTransaction", 100, 42); + final RegionServerServices rss = TEST_UTIL.createMockRegionServerService(sn); + MockRegionServerServicesWithWALs rsw = + new MockRegionServerServicesWithWALs(rss, wals.getWALProvider()); return HRegion.openHRegion(testdir, hri, htd, wals.getWAL(hri.getEncodedNameAsBytes(), hri.getTable().getNamespace()), - TEST_UTIL.getConfiguration()); + conf, rsw, null); } public static class CustomObserver extends BaseRegionObserver{ @@ -417,5 +469,239 @@ public void postRollBackSplit( } } + static class MockRegionServerServicesWithWALs implements RegionServerServices { + WALProvider provider; + RegionServerServices rss; + + MockRegionServerServicesWithWALs(RegionServerServices rss, WALProvider provider) { + this.rss = rss; + this.provider = provider; + } + + @Override + public boolean isStopping() { + return rss.isStopping(); + } + + @Override + public WAL getWAL(HRegionInfo hri) throws IOException { + return provider.getWAL(hri.getEncodedNameAsBytes(), hri.getTable().getNamespace()); + } + + @Override + public CompactionRequestor getCompactionRequester() { + return rss.getCompactionRequester(); + } + + @Override + public FlushRequester getFlushRequester() { + return rss.getFlushRequester(); + } + + @Override + public RegionServerAccounting getRegionServerAccounting() { + return rss.getRegionServerAccounting(); + } + + @Override + public TableLockManager getTableLockManager() { + return rss.getTableLockManager(); + } + + @Override + public RegionServerQuotaManager getRegionServerQuotaManager() { + return rss.getRegionServerQuotaManager(); + } + + @Override + public void postOpenDeployTasks(PostOpenDeployContext context) + throws KeeperException, IOException { + rss.postOpenDeployTasks(context); + } + + @Override + public void postOpenDeployTasks(Region r) throws KeeperException, IOException { + rss.postOpenDeployTasks(r); + } + + @Override + public boolean reportRegionStateTransition(RegionStateTransitionContext context) { + return rss.reportRegionStateTransition(context); + } + + @Override + public boolean reportRegionStateTransition( + RegionServerStatusProtos.RegionStateTransition.TransitionCode code, long openSeqNum, + HRegionInfo... hris) { + return rss.reportRegionStateTransition(code, openSeqNum, hris); + } + + @Override + public boolean reportRegionStateTransition( + RegionServerStatusProtos.RegionStateTransition.TransitionCode code, HRegionInfo... hris) { + return rss.reportRegionStateTransition(code, hris); + } + + @Override + public RpcServerInterface getRpcServer() { + return rss.getRpcServer(); + } + + @Override + public ConcurrentMap getRegionsInTransitionInRS() { + return rss.getRegionsInTransitionInRS(); + } + + @Override + public FileSystem getFileSystem() { + return rss.getFileSystem(); + } + + @Override + public Leases getLeases() { + return rss.getLeases(); + } + + @Override + public ExecutorService getExecutorService() { + return rss.getExecutorService(); + } + + @Override + public Map getRecoveringRegions() { + return rss.getRecoveringRegions(); + } + + @Override + public ServerNonceManager getNonceManager() { + return rss.getNonceManager(); + } + + @Override + public boolean registerService(Service service) { + return rss.registerService(service); + } + + @Override + public HeapMemoryManager getHeapMemoryManager() { + return rss.getHeapMemoryManager(); + } + + @Override + public double getCompactionPressure() { + return rss.getCompactionPressure(); + } + + @Override + public Set getOnlineTables() { + return rss.getOnlineTables(); + } + + @Override + public ThroughputController getFlushThroughputController() { + return rss.getFlushThroughputController(); + } + + @Override + public double getFlushPressure() { + return rss.getFlushPressure(); + } + + @Override + public MetricsRegionServer getMetrics() { + return rss.getMetrics(); + } + + @Override + public void addToOnlineRegions(Region r) { + rss.addToOnlineRegions(r); + } + + @Override + public boolean removeFromOnlineRegions(Region r, ServerName destination) { + return rss.removeFromOnlineRegions(r, destination); + } + + @Override + public Region getFromOnlineRegions(String encodedRegionName) { + return rss.getFromOnlineRegions(encodedRegionName); + } + + @Override + public List getOnlineRegions(TableName tableName) throws IOException { + return rss.getOnlineRegions(tableName); + } + + @Override + public List getOnlineRegions() { + return rss.getOnlineRegions(); + } + + @Override + public Configuration getConfiguration() { + return rss.getConfiguration(); + } + + @Override + public ZooKeeperWatcher getZooKeeper() { + return rss.getZooKeeper(); + } + + @Override + public ClusterConnection getConnection() { + return rss.getConnection(); + } + + @Override + public MetaTableLocator getMetaTableLocator() { + return rss.getMetaTableLocator(); + } + + @Override + public ServerName getServerName() { + return rss.getServerName(); + } + + @Override + public CoordinatedStateManager getCoordinatedStateManager() { + return rss.getCoordinatedStateManager(); + } + + @Override + public ChoreService getChoreService() { + return rss.getChoreService(); + } + + @Override + public void abort(String why, Throwable e) { + rss.abort(why, e); + } + + @Override + public boolean isAborted() { + return rss.isAborted(); + } + + @Override + public void stop(String why) { + rss.stop(why); + } + + @Override + public boolean isStopped() { + return rss.isStopped(); + } + + @Override + public void updateRegionFavoredNodesMapping(String encodedRegionName, + List favoredNodes) { + rss.updateRegionFavoredNodesMapping(encodedRegionName, favoredNodes); + } + + @Override + public InetSocketAddress[] getFavoredNodesForRegion(String encodedRegionName) { + return rss.getFavoredNodesForRegion(encodedRegionName); + } + } }