From 5996d636080d07e5413019e33170e0318ce4ad74 Mon Sep 17 00:00:00 2001 From: Andor Molnar <andor@cloudera.com> Date: Wed, 2 Mar 2022 18:47:04 +0100 Subject: [PATCH] HBASE-26666. Mark unit test ignored. Later we'll delete --- .../hbase/ipc/TestNettyRpcConnection.java | 104 ++++++++++++++++++ 1 file changed, 104 insertions(+) create mode 100644 hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java diff --git a/hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java b/hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java new file mode 100644 index 000000000000..9e0f20f40f5d --- /dev/null +++ b/hbase-client/src/test/java/org/apache/hadoop/hbase/ipc/TestNettyRpcConnection.java @@ -0,0 +1,104 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.ipc; + +import static org.hamcrest.CoreMatchers.instanceOf; +import static org.hamcrest.MatcherAssert.assertThat; +import static org.junit.Assert.assertThrows; +import static org.junit.Assert.fail; +import java.io.IOException; +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.lang.reflect.Modifier; +import java.util.HashSet; +import java.util.Set; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseConfiguration; +import org.apache.hadoop.hbase.net.Address; +import org.apache.hadoop.hbase.security.User; +import org.apache.hadoop.hbase.testclassification.ClientTests; +import org.apache.hadoop.hbase.testclassification.SmallTests; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Ignore; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; +import org.apache.hbase.thirdparty.com.google.common.io.Closeables; + +@Category({ ClientTests.class, SmallTests.class }) +public class TestNettyRpcConnection { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestNettyRpcConnection.class); + + private static final Logger LOG = LoggerFactory.getLogger(TestNettyRpcConnection.class); + + private static NettyRpcClient CLIENT; + + private static NettyRpcConnection CONN; + + @BeforeClass + public static void setUp() throws IOException { + CLIENT = new NettyRpcClient(HBaseConfiguration.create()); + CONN = new NettyRpcConnection(CLIENT, + new ConnectionId(User.getCurrent(), "test", Address.fromParts("localhost", 1234))); + } + + @AfterClass + public static void tearDown() throws IOException { + Closeables.close(CLIENT, true); + } + + @Ignore + @Test + public void testPrivateMethodExecutedInEventLoop() throws IllegalAccessException { + // make sure the test is executed with "-ea" + assertThrows(AssertionError.class, () -> { + assert false; + }); + + final Set<String> methodsToCheck = new HashSet<>(); + methodsToCheck.add("shutdown0"); + methodsToCheck.add("sendRequest0"); + methodsToCheck.add("connect"); + + for (Method method : NettyRpcConnection.class.getDeclaredMethods()) { + if (Modifier.isPrivate(method.getModifiers()) && !method.getName().contains("$")) { + if (!methodsToCheck.contains(method.getName())) { + LOG.info("skipping {}", method); + continue; + } + LOG.info("checking {}", method); + method.setAccessible(true); + // all private methods should be called inside the event loop thread, so calling it from + // this thread will cause the "assert eventLoop.inEventLoop();" to fail + try { + // now there is no primitive parameters for the private methods so let's pass null + method.invoke(CONN, new Object[method.getParameterCount()]); + fail("should fail with AssertionError"); + } catch (InvocationTargetException e) { + assertThat(e.getCause(), instanceOf(AssertionError.class)); + } + } + } + } +}