-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-27649 WALPlayer does not properly dedupe overridden cell versio…
…ns (#5058) Signed-off-by: Duo Zhang <zhangduo@apache.org>
- Loading branch information
1 parent
6b672cc
commit 4b7815d
Showing
4 changed files
with
233 additions
and
3 deletions.
There are no files selected for viewing
101 changes: 101 additions & 0 deletions
101
...-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/ExtendedCellSerialization.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.hadoop.hbase.mapreduce; | ||
|
||
import java.io.DataInputStream; | ||
import java.io.DataOutputStream; | ||
import java.io.IOException; | ||
import java.io.InputStream; | ||
import java.io.OutputStream; | ||
import org.apache.hadoop.hbase.ExtendedCell; | ||
import org.apache.hadoop.hbase.KeyValue; | ||
import org.apache.hadoop.hbase.KeyValueUtil; | ||
import org.apache.hadoop.hbase.PrivateCellUtil; | ||
import org.apache.hadoop.hbase.util.Bytes; | ||
import org.apache.hadoop.io.serializer.Deserializer; | ||
import org.apache.hadoop.io.serializer.Serialization; | ||
import org.apache.hadoop.io.serializer.Serializer; | ||
import org.apache.yetus.audience.InterfaceAudience; | ||
|
||
/** | ||
* Similar to CellSerialization, but includes the sequenceId from an ExtendedCell. This is necessary | ||
* so that CellSortReducer can sort by sequenceId, if applicable. Note that these two serializations | ||
* are not compatible -- data serialized by CellSerialization cannot be deserialized with | ||
* ExtendedCellSerialization and vice versa. This is ok for {@link HFileOutputFormat2} because the | ||
* serialization is not actually used for the actual written HFiles, just intermediate data (between | ||
* mapper and reducer of a single job). | ||
*/ | ||
@InterfaceAudience.Private | ||
public class ExtendedCellSerialization implements Serialization<ExtendedCell> { | ||
@Override | ||
public boolean accept(Class<?> c) { | ||
return ExtendedCell.class.isAssignableFrom(c); | ||
} | ||
|
||
@Override | ||
public ExtendedCellDeserializer getDeserializer(Class<ExtendedCell> t) { | ||
return new ExtendedCellDeserializer(); | ||
} | ||
|
||
@Override | ||
public ExtendedCellSerializer getSerializer(Class<ExtendedCell> c) { | ||
return new ExtendedCellSerializer(); | ||
} | ||
|
||
public static class ExtendedCellDeserializer implements Deserializer<ExtendedCell> { | ||
private DataInputStream dis; | ||
|
||
@Override | ||
public void close() throws IOException { | ||
this.dis.close(); | ||
} | ||
|
||
@Override | ||
public KeyValue deserialize(ExtendedCell ignore) throws IOException { | ||
KeyValue kv = KeyValueUtil.create(this.dis); | ||
PrivateCellUtil.setSequenceId(kv, this.dis.readLong()); | ||
return kv; | ||
} | ||
|
||
@Override | ||
public void open(InputStream is) throws IOException { | ||
this.dis = new DataInputStream(is); | ||
} | ||
} | ||
|
||
public static class ExtendedCellSerializer implements Serializer<ExtendedCell> { | ||
private DataOutputStream dos; | ||
|
||
@Override | ||
public void close() throws IOException { | ||
this.dos.close(); | ||
} | ||
|
||
@Override | ||
public void open(OutputStream os) throws IOException { | ||
this.dos = new DataOutputStream(os); | ||
} | ||
|
||
@Override | ||
public void serialize(ExtendedCell kv) throws IOException { | ||
dos.writeInt(PrivateCellUtil.estimatedSerializedSizeOf(kv) - Bytes.SIZEOF_INT); | ||
PrivateCellUtil.writeCell(kv, dos, true); | ||
dos.writeLong(kv.getSequenceId()); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters