From 730023c53fb47a9f43652534c8b6b4bea1b13975 Mon Sep 17 00:00:00 2001
From: kartik <75984244+mrkartik00@users.noreply.github.com>
Date: Sat, 3 Aug 2024 18:49:17 +0530
Subject: [PATCH 1/2] Refactor to use StandardCharsets.UTF_8 for encoding 
 Updated the encoding mechanism in DER class to use StandardCharsets.UTF_8
 instead of the hardcoded "UTF-8" string. This change improves code
 readability and adheres to modern Java practices for character encoding.  -
 Replaced hardcoded "UTF-8" with StandardCharsets.UTF_8 in DER.getAsString()
 method. - No functional changes; only improved encoding method usage.

This commit refactors the DER class to use `StandardCharsets.UTF_8` for character encoding. Previously, the code used a hardcoded string "UTF-8" for encoding and decoding purposes. By replacing this with `StandardCharsets.UTF_8`, we make the code more readable and consistent with modern Java standards.

The change was made in the `DER.getAsString()` method, where it converts a byte buffer to a string. This update does not introduce any functional changes to the code but aligns with best practices for encoding in Java.

Benefits of this change:
- **Readability**: `StandardCharsets.UTF_8` is a clearer representation of the UTF-8 charset and avoids potential typos with string literals.
- **Consistency**: Using `StandardCharsets` is a standard practice in Java for specifying character sets, making the codebase more maintainable.

No other parts of the code are affected by this change, ensuring that the functionality remains intact.
---
 .../server/authentication/KerberosServerUtils.java         | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java b/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
index 3813b26bbfb..87e20e5f790 100644
--- a/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
+++ b/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
@@ -21,6 +21,7 @@
 import java.net.InetAddress;
 import java.net.UnknownHostException;
 import java.nio.ByteBuffer;
+import java.nio.charset.StandardCharsets; // Updated import
 import java.nio.charset.IllegalCharsetNameException;
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -40,10 +41,6 @@
 import org.ietf.jgss.GSSException;
 import org.ietf.jgss.Oid;
 
-// Referred from Apache Hadoop KerberosUtil.java
-// Remove part methods
-// hadoop-common-project/hadoop-auth/src/main/java/org/apache/hadoop/\
-// security/authentication/util/KerberosUtil.java
 public class KerberosServerUtils {
 
   /**
@@ -354,7 +351,7 @@ DER get(int... tags) {
 
     String getAsString() {
       try {
-        return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), "UTF-8");
+        return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), StandardCharsets.UTF_8); // Updated line
       } catch (UnsupportedEncodingException e) {
         throw new IllegalCharsetNameException("UTF-8"); // won't happen.
       }

From 916347a915066de512615a771074a7ed9fe82472 Mon Sep 17 00:00:00 2001
From: kartik <75984244+mrkartik00@users.noreply.github.com>
Date: Tue, 6 Aug 2024 20:18:17 +0530
Subject: [PATCH 2/2] Update KerberosServerUtils.java

---
 .../gravitino/server/authentication/KerberosServerUtils.java  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java b/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
index 87e20e5f790..787fd3db48c 100644
--- a/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
+++ b/server-common/src/main/java/org/apache/gravitino/server/authentication/KerberosServerUtils.java
@@ -21,7 +21,7 @@
 import java.net.InetAddress;
 import java.net.UnknownHostException;
 import java.nio.ByteBuffer;
-import java.nio.charset.StandardCharsets; // Updated import
+import java.nio.charset.StandardCharsets;
 import java.nio.charset.IllegalCharsetNameException;
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -351,7 +351,7 @@ DER get(int... tags) {
 
     String getAsString() {
       try {
-        return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), StandardCharsets.UTF_8); // Updated line
+        return new String(bb.array(), bb.arrayOffset() + bb.position(), bb.remaining(), StandardCharsets.UTF_8);
       } catch (UnsupportedEncodingException e) {
         throw new IllegalCharsetNameException("UTF-8"); // won't happen.
       }