Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add final to Iceberg table event members, fix return codes for rename and exists operations #5593

Closed
orenccl opened this issue Nov 16, 2024 · 1 comment · Fixed by #5594
Assignees
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything

Comments

@orenccl
Copy link
Collaborator

orenccl commented Nov 16, 2024

What would you like to be improved?

  1. Add final to Iceberg table event members as they should not change after initialization.
  2. Based on the Iceberg Open API specification (for rename) and this reference (for exists), the rename and exists operations should return 204 instead of 200.

How should we improve?

  1. Add final to Iceberg table-related events and their members, such as IcebergCreateTableEvent.
  2. Modify the return codes in IcebergTableOperations and IcebergTableRenameOperations to align with the specification, and update the relevant unit tests.
@orenccl orenccl added the improvement Improvements on everything label Nov 16, 2024
@orenccl
Copy link
Collaborator Author

orenccl commented Nov 16, 2024

@FANNG1
I'm working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.8.0 Release v0.8.0 improvement Improvements on everything
Projects
None yet
2 participants