Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Display audit information on other entities in the Gravitino CLI #5477

Closed
justinmclean opened this issue Nov 5, 2024 · 5 comments · Fixed by #5509
Closed
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

Now that audit info is displayed on metalakes, display audit info for other entities.

How should we improve?

See above.

@justinmclean justinmclean added improvement Improvements on everything good first issue Good for newcomers labels Nov 5, 2024
@justinmclean
Copy link
Member Author

@orenccl do you want to work on this?

@justinmclean justinmclean changed the title [Improvement] Display audit information on ather entities in the Gravitino CLI [Improvement] Display audit information on other entities in the Gravitino CLI Nov 5, 2024
@orenccl
Copy link
Collaborator

orenccl commented Nov 6, 2024

I'd like to take this on. 🚀

@justinmclean
Copy link
Member Author

Thanks, I've assigned it to you.

@orenccl
Copy link
Collaborator

orenccl commented Nov 7, 2024

Hi @justinmclean,

Could I add a function called csvFormat() in Audit.java and use it like this:

String output = audit.csvFormat();

Or, alternatively, something like this:

String output = new CSVFormat(audit).handle();

@justinmclean
Copy link
Member Author

You could add that function to a base AuditCommand and have all the other Audit commands extend that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants