Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] clarify docker test failure messages #4170

Open
mchades opened this issue Jul 16, 2024 · 4 comments · May be fixed by #4944
Open

[Improvement] clarify docker test failure messages #4170

mchades opened this issue Jul 16, 2024 · 4 comments · May be fixed by #4944
Assignees
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@mchades
Copy link
Contributor

mchades commented Jul 16, 2024

What would you like to be improved?

Since the default value of skipDockerTests is true.
When user runs the docker tests task without setting skipDockerTests=false, the test will be failed but the error message is confused:

  • What went wrong:
    Execution failed for task ':integration-test:test'.

No tests found for given includes: [org.apache.gravitino.integration.test.client.AuditIT](--tests filter)

note: use ./gradlew :integration-test:test --tests "org.apache.gravitino.integration.test.client.AuditIT" to reproduce

How should we improve?

We should add configuration modification instructions in the error message to help users locate the cause of the error more easily.

@mchades mchades added good first issue Good for newcomers improvement Improvements on everything labels Jul 16, 2024
@four1er
Copy link

four1er commented Jul 23, 2024

Assign it to me, thx!

@justinmclean
Copy link
Member

@four1er do you still want to work on this?

@Naresh-kumar-Thodupunoori
Copy link
Contributor

Are you still working on it @four1er ?
If not I would like to work on it @justinmclean

@mchades
Copy link
Contributor Author

mchades commented Aug 16, 2024

Thank you for your enthusiasm! I think anyone can submit a PR at any time as long as the issue has not been resolved and there are no related PRs submitted. @Naresh-kumar-Thodupunoori

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants