Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] Improved Gradle Build Scripts for Python Module #2770

Closed
Tracked by #2113
xunliu opened this issue Apr 2, 2024 · 1 comment
Closed
Tracked by #2113

[Subtask] Improved Gradle Build Scripts for Python Module #2770

xunliu opened this issue Apr 2, 2024 · 1 comment
Labels
subtask Subtasks of umbrella issue

Comments

@xunliu
Copy link
Member

xunliu commented Apr 2, 2024

Describe the subtask

Currently, Clients/client-python/build.gradle.kts import java plugin to support gradle test command,
But the python module doesn't actually depend on this plugin, and must add below config in the build.gradle.kts.

  compileJava {
    dependsOn(pipInstall)
  }

  spotlessJava {
    dependsOn(pipInstall)
  }

Maybe we can improve this script, and delete these.

Parent issue

#2113

@xunliu
Copy link
Member Author

xunliu commented Apr 13, 2024

This issue fixed by #2753, So I closed this issue.

@xunliu xunliu closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
subtask Subtasks of umbrella issue
Projects
None yet
Development

No branches or pull requests

2 participants