-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Two classes of the same name #2284
Comments
I think it is on purpose, we don't have a better name to separate the two files. |
Give the description of one is "The FilesetCatalog interface defines the public API for managing fileset objects in a schema." could it be renamed FilesetSchema? |
I think it's not proper to rename to "FilesetSchema", Fileset and Schema are two concepts in Gravitino. Previously we chose "GravitinoFilesetCatalog", it's also a bit weird. I think we still have time to figure out a good name before release. CC @coolderli to take a look at it. |
@jerryshao Here are some new names I can think: |
@jerryshao How about |
Actually I don't think this is an issue which need to solve. |
Hey @jerryshao , I would like to work on this issue. please could you assign me this issue? |
What would you like to be improved?
We have two classes with the same name - this could be confusing:
./clients/client-java/src/main/java/com/datastrato/gravitino/client/FilesetCatalog.java
./api/src/main/java/com/datastrato/gravitino/file/FilesetCatalog.java
How should we improve?
Rename one or more of the classes.
The text was updated successfully, but these errors were encountered: