Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Two classes of the same name #2284

Open
justinmclean opened this issue Feb 21, 2024 · 7 comments
Open

[Improvement] Two classes of the same name #2284

justinmclean opened this issue Feb 21, 2024 · 7 comments
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

We have two classes with the same name - this could be confusing:
./clients/client-java/src/main/java/com/datastrato/gravitino/client/FilesetCatalog.java
./api/src/main/java/com/datastrato/gravitino/file/FilesetCatalog.java

How should we improve?

Rename one or more of the classes.

@justinmclean justinmclean added good first issue Good for newcomers improvement Improvements on everything labels Feb 21, 2024
@jerryshao
Copy link
Contributor

I think it is on purpose, we don't have a better name to separate the two files.

@justinmclean
Copy link
Member Author

Give the description of one is "The FilesetCatalog interface defines the public API for managing fileset objects in a schema." could it be renamed FilesetSchema?

@jerryshao
Copy link
Contributor

I think it's not proper to rename to "FilesetSchema", Fileset and Schema are two concepts in Gravitino. Previously we chose "GravitinoFilesetCatalog", it's also a bit weird. I think we still have time to figure out a good name before release.

CC @coolderli to take a look at it.

@coolderli
Copy link
Contributor

coolderli commented Feb 21, 2024

@jerryshao Here are some new names I can think: GenericFilesetCatalog, CommonFilesetCatalog, FileCatalog, ClientFilesetCatalog, SimpleFilesetCatalogand DefaultFilesetCatalog. Which do you prefer? Or any other suggestion?

@coolderli
Copy link
Contributor

@jerryshao Here are some new names I can think: GenericFilesetCatalog, CommonFilesetCatalog, FileCatalog, ClientFilesetCatalog, SimpleFilesetCatalogand DefaultFilesetCatalog. Which do you prefer? Or any other suggestion?

@jerryshao How about GenericFilesetCatalog?

@qqqttt123
Copy link
Contributor

Actually I don't think this is an issue which need to solve.

@Jash2606
Copy link

Hey @jerryshao , I would like to work on this issue. please could you assign me this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Development

No branches or pull requests

5 participants