Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Add the check for name validation #1652

Closed
yuqi1129 opened this issue Jan 23, 2024 · 4 comments · Fixed by #3053
Closed

[Improvement] Add the check for name validation #1652

yuqi1129 opened this issue Jan 23, 2024 · 4 comments · Fixed by #3053
Assignees
Labels
improvement Improvements on everything

Comments

@yuqi1129
Copy link
Contributor

What would you like to be improved?

Currently, we do not have any checks for the following things:

  • Name identifier check. we can limit the character in the content to avoid some unexpected issues introduced by special character like &, \ and so on.
  • K/V check. The key and value of key-value pairs should also be considered for simplicity.
  • Others

How should we improve?

No response

@yuqi1129 yuqi1129 added the improvement Improvements on everything label Jan 23, 2024
@yuqi1129
Copy link
Contributor Author

Please also see
#1429
#1633

@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Feb 4, 2024
@mchades
Copy link
Contributor

mchades commented Feb 19, 2024

The name identifier is used for the names of schemas and tables. We should investigate whether the underlying catalog also has similar checks for names, in order to make it clear to users whether this is a limitation of Gravitino or the underlying catalog.

@jerryshao
Copy link
Contributor

Either we should figure out a generic rule for all the name fields, or we can add to the catalog capabilities for each catalog.

@mchades
Copy link
Contributor

mchades commented Apr 20, 2024

This can be solved by #3053

@mchades mchades linked a pull request Apr 20, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants