From fbd19c86e8864d1bfe3ac8eab26fa6bd15a93a61 Mon Sep 17 00:00:00 2001 From: CHEYNE Date: Wed, 10 Jan 2024 15:25:55 +0800 Subject: [PATCH] [#1428] improvement(UI): Filtering empty keys when create or update (#1412) ### What changes were proposed in this pull request? Filtering empty keys when operating create or update. image After adding an empty key, the API will prompt an error message, so we need to prevent this from happening at the frontend level. ### Why are the changes needed? Fix: #1428 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A --- web/app/(home)/CreateMetalakeDialog.js | 10 ++++++---- web/app/metalakes/CreateCatalogDialog.js | 10 ++++++---- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/web/app/(home)/CreateMetalakeDialog.js b/web/app/(home)/CreateMetalakeDialog.js index ace3036012c..dc6be5cf7c8 100644 --- a/web/app/(home)/CreateMetalakeDialog.js +++ b/web/app/(home)/CreateMetalakeDialog.js @@ -91,11 +91,13 @@ const CreateMetalakeDialog = props => { } const onSubmit = data => { - const properties = innerProps.reduce((acc, item) => { - acc[item.key] = item.value + const properties = innerProps + .filter(i => i.key.trim() !== '') + .reduce((acc, item) => { + acc[item.key] = item.value - return acc - }, {}) + return acc + }, {}) const metalakeData = { ...data, diff --git a/web/app/metalakes/CreateCatalogDialog.js b/web/app/metalakes/CreateCatalogDialog.js index e2d9243854d..049a599c7d4 100644 --- a/web/app/metalakes/CreateCatalogDialog.js +++ b/web/app/metalakes/CreateCatalogDialog.js @@ -174,11 +174,13 @@ const CreateCatalogDialog = props => { .then(() => { let properties = {} - const prevProperties = innerProps.reduce((acc, item) => { - acc[item.key] = item.value + const prevProperties = innerProps + .filter(i => i.key.trim() !== '') + .reduce((acc, item) => { + acc[item.key] = item.value - return acc - }, {}) + return acc + }, {}) const { 'catalog-backend': catalogBackend,