Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Suggestions for Playground Startup Script Improvements #102

Open
orenccl opened this issue Nov 6, 2024 · 1 comment · May be fixed by #103
Open

[Improvement] Suggestions for Playground Startup Script Improvements #102

orenccl opened this issue Nov 6, 2024 · 1 comment · May be fixed by #103

Comments

@orenccl
Copy link
Contributor

orenccl commented Nov 6, 2024

Mainly suggested by @xunliu

1. Update Usage Prompt

Change the usage prompt in the startup script from:

echo "Usage: $0 [start | status | stop]"

to:

echo "Usage: $0 [start|stop|status]"

2. Optimize Port Status Output

Update the current port status output to display on a single line. For example:

  • Current output: Port 8090 is ok.
  • Suggested output: Port 8090, 9001 is ok.

3. Optimize Port In-Use Warning

Similarly, consolidate the port in-use warnings to a single line:

  • Current output: xx is in use. Please check it.
  • Suggested output: x1, x2 are in use. Please check them.

4. Remove Unnecessary Confirmation Prompt

Remove the following confirmation prompt to streamline the user experience:

Confirm the requirement is available in your OS [Y/n]:Y

5. Specify Tag for hello-world Image

Currently, the script includes the following command:

docker run --pull always hello-world >/dev/null 2>&1

To avoid unnecessary image downloads due to changes in the latest tag, specify a tag explicitly (e.g., 3.2.1).

6. Check Docker Resource Availability

The script includes a resource requirement message:

The playground requires 2 CPU cores, 8 GB of RAM, and 25 GB of disk storage to operate efficiently.

Currently, this is a text-based prompt. Consider using Docker commands to verify actual resource availability, especially ensuring that available disk space meets the 25GB requirement, to help ensure the Playground can operate smoothly.

@orenccl
Copy link
Contributor Author

orenccl commented Nov 6, 2024

I would like to work on this.

@orenccl orenccl linked a pull request Nov 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant