Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Unify HTTP Source Connector and eventmesh-webhook module #4825

Open
4 of 6 tasks
Pil0tXia opened this issue Apr 10, 2024 · 2 comments
Open
4 of 6 tasks

[Feature] Unify HTTP Source Connector and eventmesh-webhook module #4825

Pil0tXia opened this issue Apr 10, 2024 · 2 comments
Labels
feature help wanted Extra attention is needed

Comments

@Pil0tXia
Copy link
Member

Pil0tXia commented Apr 10, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Feature Request

For the eventmesh-webhook module, it currently has these shortcomings:

  • It only supports GitHub webhook protocol for now and it needs to support a more general protocol;
  • Its implementation is too unique in EventMesh, which is hard to manage and extend
  • It has some redundancy in functionality with the HTTP Source Connector and GitHub Source Connector, which needs to be revamped.

This issue brings about a change from thinking of the Runtime as an HTTP Webhook server to thinking of the Connector as an HTTP Webhook server for enhanced extensibility and manageability.

This issue can be resolved in the following steps:

  • Use the existing implementation of Webhook as an enhancement to the HTTP Source Connector, needs to be able to support the user's own implementation of a customized Webhook protocol: [Feature] Add Webhook support for HTTP Source Connector #4869
  • Supporting GitHub webhook protocol may supersed the webhook function of GitHub Source Connector, which means that there's no need to support Webhook in [Feature] Add Github source connector #4416.
  • Deprecate eventmesh-webhook module and its special usages in eventmesh-runtime. (Link the PR resolving this task to this issue.)

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@scwlkq
Copy link
Contributor

scwlkq commented Apr 11, 2024

@Pil0tXia I want to do it! Can you please assign it to me?

@Pil0tXia
Copy link
Member Author

@scwlkq You may start understanding eventmesh-webhook module from InsertWebHookConfigHandler class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants