Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue https://github.com/apache/incubator-dubbo/issues/4115 #4116

Merged
merged 1 commit into from
May 23, 2019

Conversation

zonghaishang
Copy link
Member

What is the purpose of the change

XXXXX

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@zonghaishang zonghaishang requested a review from ralf0131 May 22, 2019 09:16
@codecov-io
Copy link

Codecov Report

Merging #4116 into master will increase coverage by 0.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4116      +/-   ##
============================================
+ Coverage      62.7%   63.64%   +0.94%     
- Complexity      475      478       +3     
============================================
  Files           763      770       +7     
  Lines         32866    34380    +1514     
  Branches       5184     5621     +437     
============================================
+ Hits          20608    21882    +1274     
- Misses         9884    10059     +175     
- Partials       2374     2439      +65
Impacted Files Coverage Δ Complexity Δ
.../apache/dubbo/remoting/etcd/jetcd/JEtcdClient.java 9.31% <ø> (+0.05%) 0 <0> (ø) ⬇️
.../org/apache/dubbo/rpc/filter/CompatibleFilter.java 70.27% <0%> (-13.07%) 0% <0%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 51.42% <0%> (-11.43%) 0% <0%> (ø)
...ache/dubbo/remoting/p2p/support/AbstractGroup.java 45.45% <0%> (-11.37%) 0% <0%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 61.9% <0%> (-9.53%) 0% <0%> (ø)
...rg/apache/dubbo/rpc/filter/ExecuteLimitFilter.java 78.57% <0%> (-8.1%) 0% <0%> (ø)
.../org/apache/dubbo/remoting/ExecutionException.java 15.78% <0%> (-5.27%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 28.57% <0%> (-4.77%) 0% <0%> (ø)
...a/org/apache/dubbo/remoting/RemotingException.java 70.58% <0%> (-4.42%) 0% <0%> (ø)
...ache/dubbo/rpc/protocol/ProtocolFilterWrapper.java 87.5% <0%> (-0.74%) 0% <0%> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df084ad...7bacc82. Read the comment docs.

Copy link
Contributor

@ralf0131 ralf0131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ralf0131 ralf0131 merged commit 779fc27 into apache:master May 23, 2019
@ralf0131
Copy link
Contributor

This fix #4115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants