Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade junit to junit 5 #3148

Closed
2 tasks done
lovepoem opened this issue Jan 5, 2019 · 3 comments
Closed
2 tasks done

Upgrade junit to junit 5 #3148

lovepoem opened this issue Jan 5, 2019 · 3 comments

Comments

@lovepoem
Copy link
Member

lovepoem commented Jan 5, 2019 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.
  • I have checked the FAQ of this repository and believe that this is not a duplicate.

Environment

  • Dubbo version: 2.7.0
  • Operating System version: macos
  • Java version: 1.8

functions

  1. Upgrade junit to junit 5
  2. Upgrade the test cases

Why do this ?

  • Some new features：test extensions 、Future of JVM testing、easier parameterized tests
  • Java 8 lambda support
  • Optimized api
  • Basically compatible with junit4

Please read the referenced article 《7 reasons why you should start using JUnit 5 today》

How to write junit5 test case ?

Please see 《JUnit 5 User Guide》 : https://junit.org/junit5/docs/current/user-guide/
@lovepoem lovepoem mentioned this issue Jan 5, 2019
Merged
6 tasks
@amishra123
Copy link

could i work on this?

@lovepoem
Copy link
Member Author

lovepoem commented Jan 6, 2019

@amishra123
Now that I have completed the batch upgrade in #3149 , you can continue to complete some modules with low coverage

@lovepoem
Copy link
Member Author

close it via #3149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lovepoem @amishra123