-
Notifications
You must be signed in to change notification settings - Fork 931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce ConfigPostProcessor extension #943
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #943 +/- ##
===========================================
+ Coverage 59.92% 60.16% +0.23%
===========================================
Files 260 261 +1
Lines 12840 12895 +55
===========================================
+ Hits 7695 7758 +63
+ Misses 4186 4177 -9
- Partials 959 960 +1
Continue to review full report at Codecov.
|
@watermelo in order to give more flexibility to the implementation. I introduce an empty interface for the parameter instead of a parameter's type, since people may need to look into other infos like interface or others. |
pls. hold on, I am still working on a better idea. |
@AlexStocks @watermelo @cityiron would you mind to review the new solution again? |
introduce ConfigPostProcessor extension
What this PR does:
introduce ConfigPostProcessor extension so that user can customize configs for both ServiceConfig and ReferenceConfig further during deployment time.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: