Rft: network & codec #673
Merged
Rft: network & codec #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imp: refactor the network transport layer
fix issue for network refactor
fix: resove dev RPCResult struct change
Refact seri
Codecov Report
@@ Coverage Diff @@
## develop #673 +/- ##
===========================================
- Coverage 61.44% 59.78% -1.66%
===========================================
Files 251 259 +8
Lines 12084 12722 +638
===========================================
+ Hits 7425 7606 +181
- Misses 3766 4166 +400
- Partials 893 950 +57
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Sep 14, 2020
AlexStocks
reviewed
Sep 14, 2020
AlexStocks
approved these changes
Sep 15, 2020
feat: delete dubbo_protocol assert remoting.ExchangeClient
flycash
approved these changes
Sep 17, 2020
AlexStocks
reviewed
Sep 19, 2020
| func (p *RpcServerPackageHandler) Read(ss getty.Session, data []byte) (interface{}, int, error) { | ||
| req, length, err := (p.server.codec).Decode(data) | ||
| //resp,len, err := (*p.).DecodeResponse(buf) | ||
|
|
There was a problem hiding this comment.
pls do not left a blank line btw assignment and the if condition checker.
zouyx
reviewed
Sep 19, 2020
| } | ||
|
|
||
| // DubboCodec. It is implements remoting.Codec | ||
| type DubboCodec struct { |
| requestTimeout := config.GetConsumerConfig().RequestTimeout | ||
|
|
||
| requestTimeoutStr := url.GetParam(constant.TIMEOUT_KEY, config.GetConsumerConfig().Request_Timeout) | ||
| if t, err := time.ParseDuration(requestTimeoutStr); err == nil { |
There was a problem hiding this comment.
I think you should print error if error is not null
| invokeResult := invoker.Invoke(ctx, rpcInvocation) | ||
| if err := invokeResult.Error(); err != nil { | ||
| result.Err = invokeResult.Error() | ||
| //p.Header.ResponseStatus = hessian.Response_OK |
zouyx
approved these changes
Sep 19, 2020
zouyx
added a commit
to zouyx/dubbo-go
that referenced
this pull request
Sep 22, 2020
Rft: network & codec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: