[WIP] feature: support protobuf #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xujianhai666
changed the title
common/extension/serialization.go
Outdated
| nameMaps = make(map[byte]string) | ||
| ) | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
don't init here, refer to other extension.
|
|
||
| // doesn't encode url reserve character, url.QueryEscape will do this work | ||
| // reference: https://github.com/golang/go.git, src/net/url/url.go, Encode method | ||
| func ParamsUnescapeEncode(params url.Values) string { |
There was a problem hiding this comment.
please see Url.tostring, and then decide to keep this method or not.
| @@ -20,6 +20,7 @@ package config | |||
| import ( | |||
| "context" | |||
| "fmt" | |||
| "github.com/apache/dubbo-go/protocol/dubbo/impl/remoting" | |||
There was a problem hiding this comment.
the config dir should not referent impl.
zouyx
reviewed
Mar 31, 2020
| @@ -63,4 +64,6 @@ require ( | |||
| k8s.io/kube-openapi v0.0.0-20191107075043-30be4d16710a // indirect | |||
| ) | |||
|
|
|||
| replace github.com/apache/dubbo-go-hessian2 => /Users/jianhaixu/secrect/opensource/dubbo-go-hessian2 | |||
There was a problem hiding this comment.
should delete this replace block?
| "github.com/pkg/errors" | ||
| ) | ||
|
|
||
| /* |
| "reflect" | ||
| "regexp" | ||
|
|
||
| "github.com/pkg/errors" |
| errClientReadTimeout = perrors.New("client read timeout") | ||
| ) | ||
|
|
||
| // TODO: 需要移动到 业务的实现 |
| * limitations under the License. | ||
| */ | ||
|
|
||
| // TODO: zero.xu readwrite 中将client/server handler 分开 |
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package remoting |
There was a problem hiding this comment.
maybe add blank line between lisence and package name
| gxsync "github.com/dubbogo/gost/sync" | ||
| ) | ||
|
|
||
| // TODO: 需要移动到 业务的实现 |
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/apache/dubbo-go/common/constant" |
| "github.com/apache/dubbo-go/protocol/dubbo/impl" | ||
| "github.com/apache/dubbo-go/protocol/dubbo/impl/remoting" | ||
| "github.com/apache/dubbo-go/protocol/invocation" | ||
| "github.com/dubbogo/getty" |
Comment on lines
+31
to
+32
| "github.com/opentracing/opentracing-go" | ||
| "github.com/opentracing/opentracing-go/mocktracer" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.