Ftr: consul registry #121
Merged
Ftr: consul registry #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 21, 2019 10:31
|
Pls add unit test and resolve the conflicts. |
|
@hxmhlt Ok. |
fangyincheng
reviewed
Jul 6, 2019
added 2 commits
July 9, 2019 18:34
Codecov Report
@@ Coverage Diff @@
## develop #121 +/- ##
==========================================
+ Coverage 67.54% 67.84% +0.3%
==========================================
Files 90 93 +3
Lines 5537 5729 +192
==========================================
+ Hits 3740 3887 +147
- Misses 1403 1432 +29
- Partials 394 410 +16
Continue to review full report at Codecov.
|
added 2 commits
July 9, 2019 21:03
AlexStocks
reviewed
Aug 4, 2019
added 20 commits
August 11, 2019 13:57
hxmhlt
reviewed
Aug 22, 2019
| return err | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Why only register provider side? Where is consumer's registry?
There was a problem hiding this comment.
hxmhlt
reviewed
Aug 22, 2019
AlexStocks
reviewed
Aug 23, 2019
AlexStocks
reviewed
Aug 23, 2019
| func (r *consulRegistry) Unregister(url common.URL) error { | ||
| var err error | ||
|
|
||
| role, _ := strconv.Atoi(r.URL.GetParam(constant.ROLE_KEY, "")) |
There was a problem hiding this comment.
need not to unregister consumer?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add consul registry.
Special notes for your reviewer:
First thing that should be noticed is that this pr only support golang 1.12, because native consul api only support 1.12:
Another thing is that there are still a lot of things should be done about consul registry:
@hxmhlt @fangyincheng @AlexStocks