Imp: destroy invoker smoothly #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace ci icon
AlexStocks
force-pushed
the
feature/dubbo_invoker_reqnum
branch
from
53302a3
to
498a8f8
Compare
gaoxinge
reviewed
Feb 6, 2021
wenxuwan
reviewed
Feb 6, 2021
This comment has been minimized.
This comment has been minimized.
AlexStocks
changed the title
Codecov Report
@@ Coverage Diff @@
## 1.5 #1045 +/- ##
==========================================
- Coverage 59.53% 59.31% -0.23%
==========================================
Files 259 265 +6
Lines 12737 13137 +400
==========================================
+ Hits 7583 7792 +209
- Misses 4199 4362 +163
- Partials 955 983 +28
Continue to review full report at Codecov.
|
zouyx
reviewed
Feb 7, 2021
gaoxinge
reviewed
Feb 7, 2021
wenxuwan
reviewed
Feb 7, 2021
protocol/dubbo/dubbo_invoker.go
Outdated
| } | ||
| break | ||
| } else if times < 0 { |
There was a problem hiding this comment.
万一发生什么幺蛾子呢？防御性编程，这里面有日志的。
flycash
reviewed
Feb 7, 2021
|
这边可以用给一个原子操作代表invoker是不是可用状态，然后加一个读写锁，invoke的时候先用原子操作判断是不是可用的，如果可用加读锁，然后再通过原子操作判断一次，如果还可用，调用下面的call,完成后释放读锁。destroy的时候直接把invoker标记为不可用状态，然后阻塞获取写锁，获取成功后然后关闭invoker，释放client就可以了。 |
AlexStocks
force-pushed
the
feature/dubbo_invoker_reqnum
branch
from
ef22815
to
fa5c18e
Compare
flycash
reviewed
Feb 10, 2021
wenxuwan
reviewed
Feb 10, 2021
AlexStocks
force-pushed
the
feature/dubbo_invoker_reqnum
branch
from
9420e9e
to
211e22e
Compare
wenxuwan
reviewed
Feb 10, 2021
AlexStocks
force-pushed
the
feature/dubbo_invoker_reqnum
branch
from
211e22e
to
4a70624
Compare
gaoxinge
approved these changes
Feb 11, 2021
AlexStocks
force-pushed
the
feature/dubbo_invoker_reqnum
branch
from
4a70624
to
d84ece5
Compare
wenxuwan
approved these changes
Feb 11, 2021
zouyx
approved these changes
Feb 19, 2021
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
Imp: destroy invoker smoothly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
fix bug: protocol/dubbo/dubbo_invoker.go:DubboInvoker.reqNum should be a atomic number