Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Imp: service provider improvement todo list #59

Closed
u0x01 opened this issue May 29, 2019 · 0 comments · Fixed by #98
Closed

Imp: service provider improvement todo list #59

u0x01 opened this issue May 29, 2019 · 0 comments · Fixed by #98
Labels
enhancement New feature or request

Comments

@u0x01
Copy link

u0x01 commented May 29, 2019

service provider improvement todo list:

  • allow service provider return nil response
func (p *Provider) GetUser(userID int64) (*User, error) {
	...
	return nil, nil
}
  • allow service provider none response
func (p *Provider) SetUserInfo(userInfo *User) error {
	...
	return nil
}
  • allow service provider none request
func (p *Provider) TakeUser() (*User, error) {
	...
	return &User{}
}
  • host bind ip auto detect when not being configured
  • provider config map abstractions
conMap, _ := config.Load()
res, err := conMap["com.ikurento.user.UserProvider"].GetRPCService("com.ikurento.user.UserProvider").(*UserProvider).Echo(context.TODO(), "OK")
if err != nil {
	panic(err)
}

to

providerInstance, _ := config.Build()
res, err := providerInstance.GetRPCService("com.ikurento.user.UserProvider").(*UserProvider).Echo(context.TODO(), "OK")
if err != nil {
	panic(err)
}
@u0x01 u0x01 added the enhancement New feature or request label May 29, 2019
LaurenceLiZhixin pushed a commit to LaurenceLiZhixin/dubbo-go that referenced this issue Jul 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant