Ability to Delete task logs and segments from Azure Storage #9523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implement ability to delete all tasks logs or all task logs written before a particular date when written to Azure storage * implement ability to delete all segments from Azure deep storage
Comment on lines
91
to
93
| log.info("Deleting all segment files from Azure storage location [bucket: '%s' prefix: '%s']", | ||
| segmentConfig.getContainer(), segmentConfig.getPrefix() | ||
| ); |
There was a problem hiding this comment.
nit: formatting
Suggested change
| log.info("Deleting all segment files from Azure storage location [bucket: '%s' prefix: '%s']", | |
| segmentConfig.getContainer(), segmentConfig.getPrefix() | |
| ); | |
| log.info( | |
| "Deleting all segment files from Azure storage location [bucket: '%s' prefix: '%s']", | |
| segmentConfig.getContainer(), | |
| segmentConfig.getPrefix() | |
| ); |
| ); | ||
| } | ||
| catch (Exception e) { | ||
| log.error("Error occurred while deleting segment files from s3. Error: %s", e.getMessage()); |
There was a problem hiding this comment.
Heh, should probably be
Suggested change
| log.error("Error occurred while deleting segment files from s3. Error: %s", e.getMessage()); | |
| log.error("Error occurred while deleting segment files from Azure. Error: %s", e.getMessage()); |
| ); | ||
| } | ||
| catch (Exception e) { | ||
| log.error("Error occurred while deleting task log files from s3. Error: %s", e.getMessage()); |
There was a problem hiding this comment.
same wrong cloud
Suggested change
| log.error("Error occurred while deleting task log files from s3. Error: %s", e.getMessage()); | |
| log.error("Error occurred while deleting task log files from Azure. Error: %s", e.getMessage()); |
Comment on lines
172
to
174
| log.info("Deleting all task logs from Azure storage location [bucket: %s prefix: %s].", | ||
| config.getContainer(), config.getPrefix() | ||
| ); |
There was a problem hiding this comment.
same comment about 1 line per arg formatting if spans multiple lines
Suggested change
| log.info("Deleting all task logs from Azure storage location [bucket: %s prefix: %s].", | |
| config.getContainer(), config.getPrefix() | |
| ); | |
| log.info( | |
| "Deleting all task logs from Azure storage location [bucket: %s prefix: %s].", | |
| config.getContainer(), | |
| config.getPrefix() | |
| ); |
Comment on lines
183
to
185
| log.info("Deleting all task logs from Azure storage location [bucket: '%s' prefix: '%s'] older than %s.", | ||
| config.getContainer(), config.getPrefix(), new Date(timestamp) | ||
| ); |
There was a problem hiding this comment.
same formatting nit:
Suggested change
| log.info("Deleting all task logs from Azure storage location [bucket: '%s' prefix: '%s'] older than %s.", | |
| config.getContainer(), config.getPrefix(), new Date(timestamp) | |
| ); | |
| log.info( | |
| "Deleting all task logs from Azure storage location [bucket: '%s' prefix: '%s'] older than %s.", | |
| config.getContainer(), | |
| config.getPrefix(), | |
| new Date(timestamp) | |
| ); |
sorry there isn't a style rule for this, last we checked it wasn't possible to do, but it's been a while so it might be worth checking on again...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement ability to delete all tasks logs or all task logs
written before a particular date when written to Azure storage
implement ability to delete all segments from Azure deep storage
This PR has: