Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StreamingTaskRunner: Close the rejection period updater executor service #17490

Merged
merged 1 commit into from
Nov 19, 2024
Merged

StreamingTaskRunner: Close the rejection period updater executor service #17490

merged 1 commit into from
Nov 19, 2024

Conversation

adithyachakilam
Copy link
Contributor

Description

Closes the executor service missed in #17442

Key changed/added classes in this PR
  • SeekableStreamIndexTaskRunner.java

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@adithyachakilam adithyachakilam mentioned this pull request Nov 19, 2024
Merged
10 tasks
@suneet-s suneet-s merged commit c1d6328 into apache:master Nov 19, 2024
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suneet-s suneet-s suneet-s approved these changes

Assignees
No one assigned
Labels
Area - Ingestion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adithyachakilam @suneet-s