Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression in OvershadowableManager #9383

Closed
jihoonson opened this issue Feb 20, 2020 · 0 comments · Fixed by #9441
Closed

Performance regression in OvershadowableManager #9383

jihoonson opened this issue Feb 20, 2020 · 0 comments · Fixed by #9441

Comments

@jihoonson
Copy link
Contributor

jihoonson commented Feb 20, 2020

Affected Version

Since 0.16.

Description

OvershadowableManager was added in #7491 to manage all segments in the same time chunk. addChunk() is pretty slow when you have 1000+ segments per time chunk. Look at the below flame graph.

Screen Shot 2020-02-20 at 11 29 09 AM

There are two slow parts in addChunk().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant