Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[temporary](log) Add temporary log for debug insert into lost result (#30140)" #30382

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Revert "[temporary](log) Add temporary log for debug insert into lost result (#30140)" #30382

merged 1 commit into from
Jan 25, 2024

Conversation

HappenLee
Copy link
Contributor

This reverts commit f137d4e.

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@HappenLee
Copy link
Contributor Author

run buildall

wm1581066
wm1581066 approved these changes Jan 25, 2024
View reviewed changes
Copy link
Collaborator

@wm1581066 wm1581066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wangbo
wangbo approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 38501 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b9b3d05dd48dd920a9e823e87e5071e6c97277d8, data reload: false

------ Round 1 ----------------------------------
q1	17691	5139	5301	5139
q2	2045	135	125	125
q3	10849	1126	1176	1126
q4	10462	803	820	803
q5	7750	3115	3130	3115
q6	194	119	119	119
q7	862	494	492	492
q8	9238	1929	1936	1929
q9	7218	6366	6304	6304
q10	8200	3038	2999	2999
q11	415	194	205	194
q12	360	188	183	183
q13	17976	3352	3345	3345
q14	244	219	218	218
q15	537	505	499	499
q16	471	362	370	362
q17	931	552	491	491
q18	7366	6883	6795	6795
q19	1713	1407	1283	1283
q20	612	297	310	297
q21	2743	2395	2374	2374
q22	365	309	311	309
Total cold run time: 108242 ms
Total hot run time: 38501 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5418	5337	5313	5313
q2	325	216	214	214
q3	3310	3207	3264	3207
q4	2077	1971	2055	1971
q5	5909	5754	5894	5754
q6	202	118	114	114
q7	2307	1876	1840	1840
q8	3233	3360	3378	3360
q9	8977	8863	8834	8834
q10	4014	3819	3731	3731
q11	550	440	446	440
q12	820	610	597	597
q13	16953	3152	3133	3133
q14	282	261	273	261
q15	547	505	507	505
q16	512	467	456	456
q17	2314	1769	1823	1769
q18	9566	12520	9749	9749
q19	21947	1640	1521	1521
q20	4599	1918	1920	1918
q21	15218	5390	5356	5356
q22	2112	555	551	551
Total cold run time: 111192 ms
Total hot run time: 60594 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186125 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b9b3d05dd48dd920a9e823e87e5071e6c97277d8, data reload: false

query1	930	333	326	326
query2	6562	1929	1882	1882
query3	6708	204	199	199
query4	31977	22252	22276	22252
query5	4451	362	364	362
query6	233	155	150	150
query7	4611	257	255	255
query8	222	178	170	170
query9	8403	2616	2580	2580
query10	415	231	209	209
query11	16818	15507	15509	15507
query12	121	67	67	67
query13	1676	382	370	370
query14	10575	6961	6996	6961
query15	209	178	186	178
query16	5785	256	248	248
query17	952	468	470	468
query18	1785	254	247	247
query19	171	127	130	127
query20	69	72	62	62
query21	189	121	126	121
query22	5084	4993	4929	4929
query23	31411	30855	30657	30657
query24	5569	2780	2801	2780
query25	406	303	304	303
query26	774	146	152	146
query27	2247	286	280	280
query28	4029	1850	1838	1838
query29	899	618	614	614
query30	200	136	137	136
query31	905	739	757	739
query32	62	49	51	49
query33	412	202	206	202
query34	807	443	462	443
query35	845	788	785	785
query36	1343	1166	1125	1125
query37	93	59	54	54
query38	3431	3287	3192	3192
query39	1303	1268	1253	1253
query40	193	84	83	83
query41	37	42	35	35
query42	80	82	78	78
query43	525	451	499	451
query44	1036	690	689	689
query45	193	175	172	172
query46	1051	640	633	633
query47	1660	1548	1583	1548
query48	375	301	301	301
query49	610	277	279	277
query50	679	308	311	308
query51	5383	5100	5256	5100
query52	89	70	72	70
query53	314	248	258	248
query54	203	186	183	183
query55	79	72	75	72
query56	176	162	165	162
query57	998	900	960	900
query58	176	149	149	149
query59	2821	2749	2593	2593
query60	203	187	179	179
query61	78	88	81	81
query62	446	351	344	344
query63	276	248	255	248
query64	2540	1795	1730	1730
query65	3321	3271	3225	3225
query66	1159	313	313	313
query67	15958	15445	15103	15103
query68	11464	537	507	507
query69	607	298	290	290
query70	1584	1484	1494	1484
query71	10445	10197	10198	10197
query72	5034	2841	2805	2805
query73	2129	312	314	312
query74	7099	6452	6377	6377
query75	4882	2298	2258	2258
query76	6430	959	954	954
query77	688	229	226	226
query78	9436	8662	8845	8662
query79	979	501	510	501
query80	581	316	310	310
query81	471	204	208	204
query82	201	79	74	74
query83	131	116	112	112
query84	269	66	67	66
query85	1092	314	317	314
query86	386	371	403	371
query87	3455	3333	3363	3333
query88	3165	2195	2174	2174
query89	428	371	368	368
query90	2238	184	184	184
query91	158	123	124	123
query92	50	45	44	44
query93	1242	445	439	439
query94	1460	152	154	152
query95	514	451	445	445
query96	614	319	310	310
query97	4253	4185	4117	4117
query98	209	202	185	185
query99	959	691	686	686
Total cold run time: 285994 ms
Total hot run time: 186125 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.44 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b9b3d05dd48dd920a9e823e87e5071e6c97277d8, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.02
query3	0.22	0.06	0.06
query4	1.68	0.07	0.07
query5	0.54	0.52	0.52
query6	1.28	0.64	0.63
query7	0.02	0.02	0.01
query8	0.04	0.02	0.02
query9	0.55	0.50	0.50
query10	0.56	0.55	0.56
query11	0.12	0.09	0.08
query12	0.11	0.09	0.08
query13	0.60	0.61	0.60
query14	0.78	0.80	0.80
query15	0.79	0.77	0.77
query16	0.36	0.37	0.37
query17	1.01	1.00	1.02
query18	0.21	0.26	0.26
query19	1.83	1.82	1.81
query20	0.01	0.01	0.01
query21	15.40	0.57	0.61
query22	2.35	2.31	1.50
query23	17.40	0.92	0.69
query24	2.58	1.17	0.95
query25	0.41	0.23	0.20
query26	0.52	0.13	0.13
query27	0.04	0.05	0.06
query28	11.16	0.75	0.76
query29	12.52	3.05	3.15
query30	0.54	0.49	0.49
query31	2.79	0.35	0.35
query32	3.41	0.48	0.48
query33	3.22	3.21	3.21
query34	15.87	4.28	4.34
query35	4.27	4.30	4.24
query36	1.11	1.06	1.08
query37	0.06	0.05	0.05
query38	0.03	0.02	0.03
query39	0.02	0.01	0.02
query40	0.19	0.13	0.13
query41	0.07	0.01	0.02
query42	0.02	0.02	0.01
query43	0.03	0.02	0.02
Total cold run time: 104.81 s
Total hot run time: 30.44 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit b9b3d05dd48dd920a9e823e87e5071e6c97277d8 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       14.5 seconds inserted 10000000 Rows, about 689K ops/s

@yiguolei yiguolei merged commit dfed34e into apache:master Jan 25, 2024
44 of 47 checks passed
yiguolei pushed a commit that referenced this pull request Jan 25, 2024
@HappenLee @Doris-Extras
Revert "[temporary](log) Add temporary log for debug insert into lost…
6734fb1 
… result (#30140)" (#30382)

This reverts commit f137d4e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wm1581066 wm1581066 wm1581066 approved these changes

@jacktengg jacktengg jacktengg approved these changes

@wangbo wangbo wangbo approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@HappenLee @doris-robot @wangbo @jacktengg @wm1581066 @yiguolei @dataroaring