Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement](inverted index) improve expr evaluate_inverted_index performace and remove useless code #40600

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

airborne12
Copy link
Member

Proposed changes

Pre-allocate vectors based on an estimated or known size in vexpr evaluated_inverted_index

@airborne12
Copy link
Member Author

run buildall

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 10, 2024
Copy link
Contributor

PR approved by anyone and no changes requested.

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@airborne12 airborne12 merged commit faee56f into apache:master Sep 11, 2024
22 of 26 checks passed
@airborne12 airborne12 deleted the enhance branch September 11, 2024 06:13
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Sep 23, 2024
…rformace and remove useless code (apache#40600)

## Proposed changes
Pre-allocate vectors based on an estimated or known size in vexpr
evaluated_inverted_index
airborne12 added a commit that referenced this pull request Sep 23, 2024
airborne12 added a commit to airborne12/apache-doris that referenced this pull request Sep 29, 2024
…rformace and remove useless code (apache#40600)

## Proposed changes
Pre-allocate vectors based on an estimated or known size in vexpr
evaluated_inverted_index
airborne12 added a commit that referenced this pull request Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.2-merged reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants