Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix](core) runtime state is destroyed when spill task is run #39566

Merged
merged 1 commit into from
Aug 20, 2024
Merged

[bugfix](core) runtime state is destroyed when spill task is run #39566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions be/src/pipeline/exec/spill_utils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,18 @@ class SpillRunnable : public Runnable {
~SpillRunnable() override = default;

void run() override {
// Should lock task context before scope task, because the _state maybe
// destroyed when run is called.
auto task_context_holder = _task_context_holder.lock();
if (!task_context_holder) {
return;
}
SCOPED_ATTACH_TASK(_state);
Defer defer([&] {
std::function<void()> tmp;
std::swap(tmp, _func);
});

auto task_context_holder = _task_context_holder.lock();
if (!task_context_holder) {
return;
}

auto shared_state_holder = _shared_state_holder.lock();
if (!shared_state_holder) {
return;
Expand Down
Loading