-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix])(nereids)Support select catalog.db.table.column from xxx for nereids planner. #23221
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
(From new machine)TeamCity pipeline, clickbench performance test result: |
return Utils.qualifiedNameParts(qualifier, table.getName()); | ||
} | ||
|
||
/** | ||
* Full qualified table name, concat qualifier and name with `.` as separator. | ||
*/ | ||
public String qualifiedName() { | ||
if (qualifier.size() == 3) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we use special branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
qualifier may only contain db name or contain full name (catalog.db.table),for the first case, need to concat the table name here, for the latter case, we don't need to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…reids planner. #23221 Nereids doesn't support select table.* from table, this pr is to fix this bug. Support three layer qualifier. (catalog.database.table)
Nereids doesn't support
select table.* from table
, this pr is to fix this bug.Support three layer qualifier. (catalog.database.table)
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...