[improvement](agg) Do not serialize bitmap to string #23172
Conversation
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
mrhhsg
force-pushed
the
agg_bitmap_opt
branch
2 times, most recently
from
adb2c16 to
00d66c8
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
| @@ -1619,7 +1619,7 @@ public class Config extends ConfigBase { | |||
| * Max data version of backends serialize block. | |||
| */ | |||
| @ConfField(mutable = false) | |||
| public static int max_be_exec_version = 2; | |||
| public static int max_be_exec_version = 3; | |||
There was a problem hiding this comment.
Add comment here, why need change be exec version to 3??
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
| col.resize(num_rows); | ||
| auto* data = col.get_data().data(); | ||
| for (size_t i = 0; i != num_rows; ++i) { | ||
| data[i] = this->data(places[i] + offset).value; |
There was a problem hiding this comment.
better use std::move(this->data(places[i] + offset).value)
| auto& col = assert_cast<ColumnBitmap&>(to); | ||
| size_t old_size = col.size(); | ||
| col.resize(old_size + 1); | ||
| col.get_data()[old_size] = this->data(place).value; |
There was a problem hiding this comment.
seems better use std::move?
github-actions
bot
removed
the
approved
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
Proposed changes
There is no need to serialize bitmap into a string because bitmap can be serialized into protobuf.
T his PR need to pick to 2.0.1 for user case.
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...