-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](external statistics)Fix external stats collection bugs. #22788
Conversation
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some regression test
run buildall |
Support show cached table stats Support alter column stats.
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
…pache#22788) 1. Collect external table row count when execute analyze database. 2. Support show cached table stats (row count) 3. Support alter external table column stats. 4. Refresh/Invalidate table row count stat memory cache when analyze task finished and drop table stats.
…pache#22788) 1. Collect external table row count when execute analyze database. 2. Support show cached table stats (row count) 3. Support alter external table column stats. 4. Refresh/Invalidate table row count stat memory cache when analyze task finished and drop table stats.
This pr has four changes:
Proposed changes
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...