[Enhancement](binlog) Add Barrier log into BinlogManager #22559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR approved by anyone and no changes requested. |
|
run buildall |
Signed-off-by: Jack Drogon <[email protected]>
JackDrogon
force-pushed
the
feature/add_barrierlog_into_binlogmanager
branch
from
1c82b97 to
7545634
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
|
(From new machine)TeamCity pipeline, clickbench performance test result: |
xiaokang
pushed a commit
to xiaokang/doris
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Jack Drogon <[email protected]>
xiaokang
pushed a commit
that referenced
this pull request
Aug 11, 2023
Signed-off-by: Jack Drogon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add Barrier log into BinlogManager
Further comments
If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...