Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-1.1-lts](cherry-pick) Fix brpc causing query mem tracker to be inaccurate and deadlock #13697

Conversation

xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Oct 26, 2022

Proposed changes

Issue Number: close #xxx

Problem summary

cherry-pick #13401, #13528, #13697

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at [email protected] by explaining why you chose the solution you did and what alternatives you considered, etc...

@dataalive dataalive added the usercase Important user case type label label Oct 26, 2022
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 7b74101 into apache:branch-1.1-lts Oct 27, 2022
@yiguolei
Copy link
Contributor

yiguolei commented Oct 31, 2022

Pls not merge it. I will merge it until it is stable on master since many people are using 1.1.x .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/merged-1.1.4 usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants