From faf97d6ad4a55bd5e5ade68aa1eb8399701b5ef7 Mon Sep 17 00:00:00 2001
From: BiteTheDDDDt <952130278@qq.com>
Date: Sat, 30 Jul 2022 21:25:12 +0800
Subject: [PATCH] add a fault check for create_rowset to prevent meta corrupt

---
 be/src/olap/data_dir.cpp |  4 ++--
 be/src/olap/tablet.cpp   |  1 +
 be/src/olap/tablet.h     | 13 +++++++++++++
 3 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/be/src/olap/data_dir.cpp b/be/src/olap/data_dir.cpp
index baf51034e6a266..e8d99a9ae235da 100644
--- a/be/src/olap/data_dir.cpp
+++ b/be/src/olap/data_dir.cpp
@@ -469,8 +469,8 @@ Status DataDir::load() {
         if (!create_status) {
             LOG(WARNING) << "could not create rowset from rowsetmeta: "
                          << " rowset_id: " << rowset_meta->rowset_id()
-                         << " rowset_type: " << rowset_meta->rowset_type()
-                         << " rowset_state: " << rowset_meta->rowset_state();
+                         << ", rowset_type: " << rowset_meta->rowset_type()
+                         << ", rowset_state: " << rowset_meta->rowset_state();
             continue;
         }
         if (rowset_meta->rowset_state() == RowsetStatePB::COMMITTED &&
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index 75e64f875ee593..d8595c52be5abc 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -1681,6 +1681,7 @@ void Tablet::_init_context_common_fields(RowsetWriterContext& context) {
 }
 
 Status Tablet::create_rowset(RowsetMetaSharedPtr rowset_meta, RowsetSharedPtr* rowset) {
+    RETURN_IF_ERROR(check_valid());
     return RowsetFactory::create_rowset(&tablet_schema(), tablet_path(), rowset_meta, rowset);
 }
 
diff --git a/be/src/olap/tablet.h b/be/src/olap/tablet.h
index adacb11eb2f279..ef4a7231e5e933 100644
--- a/be/src/olap/tablet.h
+++ b/be/src/olap/tablet.h
@@ -25,6 +25,7 @@
 #include <unordered_set>
 #include <vector>
 
+#include "common/status.h"
 #include "gen_cpp/AgentService_types.h"
 #include "gen_cpp/MasterService_types.h"
 #include "gen_cpp/olap_file.pb.h"
@@ -282,6 +283,18 @@ class Tablet : public BaseTablet {
         return _tablet_meta->all_beta();
     }
 
+    Status check_valid() {
+        if (_tablet_meta->all_rs_metas().empty()) {
+            return Status::Corruption("tablet_schema.all_rs_metas is empty.");
+        }
+        for (auto meta : _tablet_meta->all_rs_metas()) {
+            if (!meta.get() || !meta->tablet_schema()) {
+                return Status::Corruption("tablet_schema have null meta.");
+            }
+        }
+        return Status::OK();
+    }
+
     const TabletSchema& tablet_schema() const override;
 
     Status create_rowset_writer(const Version& version, const RowsetStatePB& rowset_state,