[cherry-pick](branch-3.0) Pick "[Enhancement](MS) Add fix tablet data size api for meta service (#41782)" #43460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Check List (For Author)
Check List (For Reviewer who merge this PR)
|
|
run buildall |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -17,13 +17,22 @@ | |||
|
|
|||
| #include "meta-service/meta_service_tablet_stats.h" | |||
There was a problem hiding this comment.
warning: 'meta-service/meta_service_tablet_stats.h' file not found [clang-diagnostic-error]
#include "meta-service/meta_service_tablet_stats.h"
^| return st; | ||
| } | ||
|
|
||
| MetaServiceResponseStatus fix_tablet_stats_internal( |
There was a problem hiding this comment.
warning: function 'fix_tablet_stats_internal' exceeds recommended size/complexity thresholds [readability-function-size]
MetaServiceResponseStatus fix_tablet_stats_internal(
^Additional context
cloud/src/meta-service/meta_service_tablet_stats.cpp:196: 125 lines including whitespace and comments (threshold 80)
MetaServiceResponseStatus fix_tablet_stats_internal(
^| @@ -19,6 +19,8 @@ | |||
|
|
|||
| #include <gen_cpp/cloud.pb.h> | |||
There was a problem hiding this comment.
warning: 'gen_cpp/cloud.pb.h' file not found [clang-diagnostic-error]
#include <gen_cpp/cloud.pb.h>
^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pick #41782