[Improvement][API][num-8] add ProcessTaskRelationServiceImpl.createProcessTaskRelation #6970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dev_api2 merge from upstream dev
Codecov Report
@@ Coverage Diff @@
## dev #6970 +/- ##
============================================
- Coverage 32.90% 32.80% -0.11%
+ Complexity 1625 1620 -5
============================================
Files 432 432
Lines 14379 14379
Branches 1446 1446
============================================
- Hits 4732 4717 -15
- Misses 9191 9204 +13
- Partials 456 458 +2
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
caishunfeng
reviewed
Nov 24, 2021
| } | ||
| int insert = processTaskRelationMapper.batchInsert(processTaskRelationLogs); | ||
| int insertLog = processTaskRelationLogMapper.batchInsert(processTaskRelationLogs); | ||
| if ((insert & insertLog) > 0) { |
There was a problem hiding this comment.
Maybe this judge condition is not always correct, such as 1&2=0
There was a problem hiding this comment.
If this scenario occurs, there is a problem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6772
Adding tasks to workflow, adding upstream dependencies, and adding downstream dependencies