-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX-#6505][Dao] upgrade the MySQL driver package for building MySQL jdbcUrl #6708
Conversation
…rameter to the static parameter APPEND_PARAMS for building MySQL jdbcUrl * replace com.mysql.jdbc.Driver everywhere with com.mysql.cj.jdbc.Driver * append useSSL=false after the static parameter APPEND_PARAMS
.../main/java/org/apache/dolphinscheduler/common/datasource/mysql/MysqlDatasourceProcessor.java
Outdated
Show resolved
Hide resolved
# Conflicts: # dolphinscheduler-task-plugin/dolphinscheduler-task-api/src/main/java/org/apache/dolphinscheduler/plugin/task/datasource/mysql/MysqlDatasourceProcessor.java
# Conflicts: # docker/build/conf/dolphinscheduler/datasource.properties.tpl # dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java # dolphinscheduler-dao/src/main/resources/datasource.properties # install.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now.
Hi @lyggyhmm , to target specific issue from PR, we recommend use keyword |
Wait a minute, why should we add file |
It seems that there was this file before. It is not enough to see that it was deleted on the 14th in the submission record. It may be that I had a little accident during fetch. |
Thank you for your guidance. This is the first time I mention PR here. I may not do well in some places. I will continue to improve in the future. |
Hi @lyggyhmm you could reopen this PR, and just edited PR describe, we would help you finish your work. |
Now, I modified the PR according to your prompts and re-edited the PR description. Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @ruanwenjun could you please take a look? If all thing done maybe it could merge to dev now
Codecov Report
@@ Coverage Diff @@
## dev #6708 +/- ##
============================================
+ Coverage 33.07% 33.08% +0.01%
- Complexity 1619 1620 +1
============================================
Files 433 433
Lines 14292 14292
Branches 1427 1427
============================================
+ Hits 4727 4729 +2
+ Misses 9116 9111 -5
- Partials 449 452 +3
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, If no other concern, I will merge this pr tomorrow.
@lyggyhmm Pr merged, thanks for your contribution, this is your first contribution, you can contact to @zhongjiajie or me by email, we will help you join developer discussion groups. |
Hi @lyggyhmm , thanks for your contribution and welcome to join community 🎉 . If you want contribute but could not find issue, maybe you could start in #5689 or just search our issue list https://github.com/apache/dolphinscheduler/issues. Looking forward to your next contribution |
Thank you for your affirmation! In my spare time, I will continue to pay attention to the dynamics of the DS community and continue to contribute my own strength! I have been in the DS seed incubator group before, and would like to ask if I can join the contributor group now |
Thank you for your affirmation! It’s an honor to join the community, and I still need your advice in the future |
@lyggyhmm Will connect you in seed incubator wechat group |
Purpose of the pull request
fix #6505 upgrade the MySQL driver package for building MySQL jdbcUrl
Brief change log