Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [Api] Logback file STDOUT duplicate #14966

Merged
merged 2 commits into from
Sep 26, 2023
Merged

[Bug] [Api] Logback file STDOUT duplicate #14966

merged 2 commits into from
Sep 26, 2023

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Sep 26, 2023

@qingwli qingwli self-assigned this Sep 26, 2023
fuchanghai
fuchanghai requested changes Sep 26, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @qingwli I think we should delete the content in the if tag, otherwise the application will not print logs when running on the physical machine.

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@qingwli
Copy link
Member Author

qingwli commented Sep 26, 2023

hi @qingwli I think we should delete the content in the if tag, otherwise the application will not print logs when running on the physical machine.

Hi, in machine will print log into files

ruanwenjun
ruanwenjun approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge improvement make more easy to user or prompt friendly 3.2.1 labels Sep 26, 2023
@ruanwenjun ruanwenjun added this to the 3.2.1 milestone Sep 26, 2023
@qingwli qingwli merged commit 8cb765b into apache:dev Sep 26, 2023
53 checks passed
@qingwli qingwli deleted the fix-api-log branch September 26, 2023 12:19
@zhongjiajie zhongjiajie modified the milestones: 3.2.1, 3.2.0 Oct 11, 2023
zhongjiajie pushed a commit that referenced this pull request Oct 11, 2023
@qingwli @zhongjiajie
[Bug] [Api] Logback file STDOUT duplicate (#14966)
62275e9 
(cherry picked from commit 8cb765b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchanghai fuchanghai fuchanghai requested changes

@ruanwenjun ruanwenjun ruanwenjun approved these changes

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

Assignees

@qingwli qingwli

Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

[Bug] [Api] Logback file STDOUT duplicate
4 participants
@qingwli @ruanwenjun @fuchanghai @zhongjiajie