Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fault tolerant enviroment missing #14735

Merged

Conversation

jieguangzhou
Copy link
Member

Purpose of the pull request

close: #14734

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@jieguangzhou jieguangzhou force-pushed the fix/fault-tolerant-environment-errors branch from eac5724 to 22e090e Compare August 11, 2023 05:50
@jieguangzhou jieguangzhou self-assigned this Aug 11, 2023
@jieguangzhou jieguangzhou added this to the 3.2.0 milestone Aug 11, 2023
@jieguangzhou jieguangzhou added the bug Something isn't working label Aug 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #14735 (5aefb2e) into dev (93b0283) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 5aefb2e differs from pull request most recent head 22e090e. Consider uploading reports for the commit 22e090e to get more accurate results

@@            Coverage Diff            @@
##                dev   #14735   +/-   ##
=========================================
  Coverage     38.69%   38.69%           
- Complexity     4625     4627    +2     
=========================================
  Files          1285     1285           
  Lines         43971    43972    +1     
  Branches       4858     4856    -2     
=========================================
+ Hits          17014    17017    +3     
+ Misses        25077    25075    -2     
  Partials       1880     1880           
Files Changed Coverage Δ
.../server/master/runner/WorkflowExecuteRunnable.java 10.12% <0.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@zhongjiajie zhongjiajie merged commit 8e64026 into apache:dev Aug 11, 2023
52 checks passed
biaoma-ty pushed a commit to Kasma-Inc/dolphinscheduler that referenced this pull request Aug 17, 2023
zhongjiajie pushed a commit that referenced this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Environment configuration lost during fault tolerance
3 participants